Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXWEB2-389 Dynamic heights for variable boxes #338

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

oyessb
Copy link
Contributor

@oyessb oyessb commented Nov 13, 2024

Set height for Virtuoso list to calculated total height if total is less than 380px high.

Copy link

cloudflare-workers-and-pages bot commented Nov 13, 2024

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd674c6
Status: ✅  Deploy successful!
Preview URL: https://4b20f3c2.pxweb2.pages.dev
Branch Preview URL: https://feature-pxweb2-389-variableb.pxweb2.pages.dev

View logs

@oyessb oyessb marked this pull request as ready for review November 13, 2024 10:37
@oyessb oyessb requested review from a team November 13, 2024 10:37
Copy link
Contributor

@PerIngeVaaje PerIngeVaaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK!

@PerIngeVaaje PerIngeVaaje merged commit 23b8063 into main Nov 13, 2024
8 checks passed
@PerIngeVaaje PerIngeVaaje deleted the feature/PXWEB2-389-variablebox-dynamic-height branch November 13, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants