Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pxweb2 319 add metainfo to cells #337

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

PerIngeVaaje
Copy link
Contributor

Added metainfo used for screenreaders

Added scope in row and column headers
Added Id in header and headers in datacells.
@PerIngeVaaje PerIngeVaaje requested review from SjurSutterudSagen, oyessb and a team and removed request for SjurSutterudSagen and oyessb November 13, 2024 08:56
Copy link
Contributor

@oyessb oyessb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with NVDA. Reads table as expected 👍
Note about empty table header is added in Jira.

Copy link

cloudflare-workers-and-pages bot commented Nov 14, 2024

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: b9fbb92
Status: ✅  Deploy successful!
Preview URL: https://7a46254c.pxweb2.pages.dev
Branch Preview URL: https://feature-pxweb2-319-add-metai.pxweb2.pages.dev

View logs

@PerIngeVaaje PerIngeVaaje marked this pull request as ready for review November 14, 2024 09:42
@PerIngeVaaje PerIngeVaaje merged commit 2750dd6 into main Nov 14, 2024
8 checks passed
@PerIngeVaaje PerIngeVaaje deleted the feature/PXWEB2-319-Add-metainfo-to-cells branch November 14, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants