Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pxweb2 384 fix unit tests for variable box #334

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

michaelpande
Copy link
Contributor

@michaelpande michaelpande commented Nov 11, 2024

preload fonts and fix unit tests for variable box so that it uses a mocked version of react virtuoso

@michaelpande michaelpande requested review from a team November 11, 2024 14:19
Copy link

cloudflare-workers-and-pages bot commented Nov 11, 2024

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: b9b4ce5
Status: ✅  Deploy successful!
Preview URL: https://716b862a.pxweb2.pages.dev
Branch Preview URL: https://pxweb2-384-fix-unit-tests-fo.pxweb2.pages.dev

View logs

@michaelpande michaelpande force-pushed the PXWEB2-384-fix-unit-tests-for-variable-box branch from 9023356 to b9b4ce5 Compare November 11, 2024 14:22
Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@michaelpande michaelpande merged commit 16b81b8 into main Nov 12, 2024
9 checks passed
@michaelpande michaelpande deleted the PXWEB2-384-fix-unit-tests-for-variable-box branch November 12, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants