Sticky items for search/select are added by topItemCount prop. When s… #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crolling down a custom TopItemList i used to override sticky div with empty fragment.
… will triggered for every scroll change.
Deploying pxweb2 with
|
| Latest commit: |
37fec93
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://54571552.pxweb2.pages.dev |
| Branch Preview URL: | https://feature-pxweb2-372-sticky-sc-su0k.pxweb2.pages.dev |
…rgin sensitivity for scroll. Remove sticky only if search is empty.
SjurSutterudSagen
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Looks good, behaves as expected when scrolling, except that one bug when scrolling very slowly. But as I said, I think that one can be fixed when looking into animations. Might be quite technical with virtuoso, and no point spending loads of time now fixing it, if we can't get the animations to work properly anyways, or the other way around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…crolling down a custom TopItemList i used to override sticky div with empty fragment.