Added all semantically named colors #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pxweb2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michaelpande
force-pushed
the
PXWEB2-58-colors
branch
from
0f494fa to
a9f19a3
Compare
SjurSutterudSagen
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Can't really comment on what we lose/gain by having the colours directly in this file, instead of a different one with the names the designers use like 'red-400' and importing those. I've never worked with a system like this, or designers, so I'll just trust in your greater experience here :)
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all semantically named colors