Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests work #129

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Make tests work #129

merged 2 commits into from
Apr 25, 2024

Conversation

MikaelNordberg
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 25, 2024 •
edited
Loading

Deploying pxweb2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d1f2a9
Status: ✅  Deploy successful!
Preview URL: https://d69f830f.pxweb2.pages.dev
Branch Preview URL: https://fix-fix-modal-test.pxweb2.pages.dev

View logs

SjurSutterudSagen
SjurSutterudSagen previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how the PR checks behave with a failing test that is changed

@SjurSutterudSagen
Copy link
Contributor

The tests are the only checks that have failed, and the PR can't be merged. Working as intended then :)

@MikaelNordberg MikaelNordberg changed the title Partial fix Make tests work Apr 25, 2024
SjurSutterudSagen
SjurSutterudSagen approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@SjurSutterudSagen SjurSutterudSagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving removing the test for modal here, since we just need the main branch's ci run to finish without failing on the tests.

@MikaelNordberg MikaelNordberg merged commit 6262843 into main Apr 25, 2024
8 checks passed
@MikaelNordberg MikaelNordberg deleted the Fix/Fix-Modal-test branch April 25, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SjurSutterudSagen SjurSutterudSagen SjurSutterudSagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikaelNordberg @SjurSutterudSagen