Datareader errorhandling improvements #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jsaarimaa
commented
Nov 13, 2024
jsaarimaa
commented
- Changed the datareader interface to use maps instead of the indexer objects.
- Added checking that thet the target map is a submap of the complete map.
- Datareader now throws a exception if the data is beinf read in a wrong order.
- Updated the README
…reading the stream. Improved unit testing for the data indexer and data reading.
sakari-malkki
approved these changes
Nov 13, 2024
sakari-malkki
deleted the
feature/datareader-errorhandling-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.