Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc updates #22

Merged
merged 3 commits into from
May 1, 2024
Merged

Misc updates #22

merged 3 commits into from
May 1, 2024

Conversation

likp
Copy link
Contributor

@likp likp commented Apr 30, 2024 •
edited
Loading

Added following changes before moving it to pxtools

  • Updatade nuget refrences
  • Change target framework for the unit test project to .NET 8
  • Removed all warnings

@likp likp marked this pull request as ready for review April 30, 2024 13:11
@likp likp requested review from runejo and JohannesFinsveen April 30, 2024 13:11
JohannesFinsveen
JohannesFinsveen approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@JohannesFinsveen JohannesFinsveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@likp likp merged commit 908531f into master May 1, 2024
@likp likp deleted the misc/updates branch May 1, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesFinsveen JohannesFinsveen JohannesFinsveen approved these changes

@runejo runejo Awaiting requested review from runejo runejo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@likp @JohannesFinsveen