OTT-105: Video Completion Rate Feature #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OTT-105_VCR: basic changes * OTT-105: Changes for injecting Tracking Events * OTT-130_VCR: Added framework with unit tests for injecting Video Event trackers in VAST * OTT-130_VCR: Reverted Path replace * OTT-130: Replaced etree dep with original repository * OTT-130: Refactored as per latest master * OTT-130: Refactored * OTT-130: Refactored * OTT-130: Reverted unwanted changes * OTT-130: Added unit tests and refactoring * OTT-130: InjectVideoEventTrackers will now return error if any * OTT-130: Refactored * OTT-130: Removed custom macro support * OTT-130: Reverted the unwanted changes * OTT-130: Reverted unwanted changes * OTT-130: Added Url Query Escape Functionality * OTT-130: Fixed test failures * OTT-130: Refactored * OTT-130: Addressed code review comments from Viral Co-authored-by: Shriprasad <[email protected]>
* OTT-131: Added support for consuming the custom macros from host company * OTT-131: Removed unwanted comments * OTT-131: Addressed code review comments Co-authored-by: Shriprasad <[email protected]>
…ndling change (#134) * OTT-174: Added AdUnit parameter inside video event tracker URL * OTT-174: Added bid id, au tracker parameters. in case of advetiser_id, OW will now send only value at index 0 from bid.ADomain array by extracting the domain Also handled the CTV/Ad Pod bid.id custom use case * OTT-174: Ensured bidid value is replaced only in case of OW trackers. (95% reliable) Also ensured that bidid is not getting added to other trackers, if not present * OTT-174: Fixed code review comments Co-authored-by: Shriprasad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Forming and Injecting Video Event Trackers inside VAST