Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis #503

Merged
merged 14 commits into from
Jan 15, 2018
Merged

Travis #503

merged 14 commits into from
Jan 15, 2018

Conversation

merlokk
Copy link
Contributor

@merlokk merlokk commented Dec 2, 2017

add travis.ci from @pwpiwi repository

@merlokk
Copy link
Contributor Author

merlokk commented Dec 2, 2017

changes here Proxmark/homebrew-proxmark3#15 also needs to be merged.
works without changes in rb file
just need to add environment variable REPOSITORY_EP to travis settings. for me it contains merlokk/proxmark3

@merlokk
Copy link
Contributor Author

merlokk commented Dec 2, 2017

Tested. works. https://travis-ci.org/merlokk/proxmark3

@merlokk
Copy link
Contributor Author

merlokk commented Dec 2, 2017

and this:
https://blog.travis-ci.com/2017-11-21-xcode8-3-default-image-announce

In order to streamline our image catalog, on 15 November 2017 we will be simplifying our image offerings to the following:

osx_image: xcode9.1
osx_image: xcode9
osx_image: xcode8.3 (Default)
osx_image: xcode7.3
osx_image: xcode6.4
The following images will be deprecated:

osx_image: xcode8.2
osx_image: xcode8.1
osx_image: xcode8

maybe it needs to check xcode 9 instead of xcode 8 & 8.1?

@merlokk
Copy link
Contributor Author

merlokk commented Dec 2, 2017

It works. so...
Ready to merge)

iceman1001 added a commit to iceman1001/proxmark3 that referenced this pull request Dec 2, 2017
@merlokk
Copy link
Contributor Author

merlokk commented Dec 2, 2017

lets merge)

@iceman1001
Copy link
Member

Nop. I am not convinced about your solution.

@merlokk
Copy link
Contributor Author

merlokk commented Dec 2, 2017

What it needs to add?

@merlokk
Copy link
Contributor Author

merlokk commented Dec 2, 2017

and now?

@marshmellow42
Copy link
Contributor

Adding Travis to master was discussed before, and turned down in favor of forks using it before things are committed. I'm on the fence myself.

@micolous
Copy link
Contributor

micolous commented Dec 3, 2017

I'd like it if proxmark3 was library-like enough that we can run some tests. But this wouldn't handle a lot of platform specific issues, particularly weird serial communication issues on single platforms -- which I'd argue is the biggest risk.

@merlokk
Copy link
Contributor Author

merlokk commented Dec 3, 2017

OK. you dont need to config travis on proxmark and so on. lets just add this file to master. and if someone needs to use travis - he just setup it. if dont needs - there will be just one unused file in the root...

@pwpiwi
Copy link
Contributor

pwpiwi commented Dec 28, 2017

It is not "just an unused file in the root". Pulling from this repository will overwrite each developers .travis.yml file. I am not convinced that we should do that.

Proposal: we could add a directory "Testing" which would include the testing related files (the appveyor file would go there too) and some instructions how to use it.

@merlokk
Copy link
Contributor Author

merlokk commented Jan 2, 2018

ok, i will change the PR

@merlokk
Copy link
Contributor Author

merlokk commented Jan 6, 2018

as for appveyor: move it too?

@pwpiwi
Copy link
Contributor

pwpiwi commented Jan 7, 2018

I would propose: yes.

@merlokk
Copy link
Contributor Author

merlokk commented Jan 7, 2018

moved.

@merlokk
Copy link
Contributor Author

merlokk commented Jan 7, 2018

can be merged?

@merlokk
Copy link
Contributor Author

merlokk commented Jan 15, 2018

merge plz)

@iceman1001 iceman1001 merged commit 138a0e7 into Proxmark:master Jan 15, 2018
@merlokk merlokk deleted the travis branch September 6, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants