-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis #503
Travis #503
Conversation
changes here Proxmark/homebrew-proxmark3#15 also needs to be merged. |
Tested. works. https://travis-ci.org/merlokk/proxmark3 |
and this:
maybe it needs to check xcode 9 instead of xcode 8 & 8.1? |
It works. so... |
lets merge) |
Nop. I am not convinced about your solution. |
What it needs to add? |
and now? |
Adding Travis to master was discussed before, and turned down in favor of forks using it before things are committed. I'm on the fence myself. |
I'd like it if proxmark3 was library-like enough that we can run some tests. But this wouldn't handle a lot of platform specific issues, particularly weird serial communication issues on single platforms -- which I'd argue is the biggest risk. |
OK. you dont need to config travis on proxmark and so on. lets just add this file to master. and if someone needs to use travis - he just setup it. if dont needs - there will be just one unused file in the root... |
It is not "just an unused file in the root". Pulling from this repository will overwrite each developers .travis.yml file. I am not convinced that we should do that. Proposal: we could add a directory "Testing" which would include the testing related files (the appveyor file would go there too) and some instructions how to use it. |
ok, i will change the PR |
as for appveyor: move it too? |
I would propose: yes. |
moved. |
can be merged? |
merge plz) |
add travis.ci from @pwpiwi repository