Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make terms and conditions configurable #7

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

proxeus-dev
Copy link

@proxeus-dev proxeus-dev commented Sep 23, 2019

Pull Request Details

Removes hard-coded Terms & conditions and displays them based on the link configured in the translations.

Description

Removes hard-coded Terms & conditions from Login.vue, AdminLogin.vue & RegisterRequest.vue.
Adds "Terms & Condition link" to Translation.

Related Issue

Motivation and Context

Terms & Conditions should be configurable by the platform operator.

How Has This Been Tested

Test with "Terms & Condition link" set to '' -> no T&C displayed.
Test with Link in "Terms & Condition link" -> T&C displayed

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the coding style document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@proxeus-github proxeus-github merged commit aec985a into master Sep 23, 2019
@ianaz ianaz deleted the configurable-terms-and-conditions branch February 25, 2020 13:11
alexblockfactory pushed a commit that referenced this pull request Mar 13, 2020
alexblockfactory pushed a commit that referenced this pull request Mar 13, 2020
alexblockfactory pushed a commit that referenced this pull request Mar 13, 2020
alexblockfactory pushed a commit that referenced this pull request Mar 13, 2020
alexblockfactory pushed a commit that referenced this pull request Mar 13, 2020
alexblockfactory pushed a commit that referenced this pull request Mar 13, 2020
tafonina added a commit that referenced this pull request Jun 9, 2023
Fix preview document bug (#295) reverse sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants