Merge to preprod #565
Merge to preprod #565
Conversation
reverse merge from preprod to s-pro dev
feature/fix-web3-method-fromAscii
feature/fix-web3-method-fromAscii
sync Preprod branch from main repo
…-methods remove outdated methods of old smart contract
feature/verify-doc
… into feature/verify-doc
Feature/verify doc
fix invalid character, updates in BN lib
Feature/delete property
fix frontend error message for file not found
| @@ -1569,7 +1568,7 @@ function condition(){ | |||
| }, | |||
| icon: { | |||
| face: 'Material Design Icons', | |||
| code: '\uf48a', | |||
| code: '', | |||
There was a problem hiding this comment.
It looks like you're using the Unicode character here instead of the code-string. Why?
There was a problem hiding this comment.
@slavas490 says he tried to use the hexadecimal string, but it did not work. There seems to be a problem with an unsupported library.
| @@ -1133,7 +1133,7 @@ function condition(){ | |||
| // enable inertial throwing | |||
| inertia: false, | |||
| onstart: function (event) { | |||
| if (event.interaction.downEvent.button === 2) { | |||
| if (event?.interaction?.downEvent?.button === 2) { | |||
There was a problem hiding this comment.
Is there some problem with this event?
There was a problem hiding this comment.
Slava says the specs for the third party library we use for drag-and-drop (Interact.js) was changed some time ago, and we should ideally rewrite this piece of code. E.g. start and stop not onstart and onstop
| _.tl.y + 'px)' | ||
| const translatePos = 'translate(' + _.tl.x + 'px, ' + _.tl.y + 'px)' | ||
| _.$dragComp[0].style.webkitTransform = translatePos | ||
| _.$dragComp[0].setAttribute('style', 'transform: ' + translatePos) |
There was a problem hiding this comment.
Looks like you're improving the way nodes are being moved. Please document the change in the Pull Request.
There was a problem hiding this comment.
The original code prevents us from moving the nodes. I approve Slava's code with the disclaimer above.
|
Test failed due to temporary network issue. |
Pull Request Details
Fixed Issues: