Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo in user interface auto-resize and centered (#207) #209

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

alvaro-ricotta
Copy link
Contributor

Logo in user interface auto-resize and centered has been fixed.

Pull Request Details

Description

Logo in user interface auto-resize and centered

Related Issue

#207
Issue template

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the coding style document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Logo in user interface auto-resize and centered has been fixed.
@VivienFuhrer VivienFuhrer requested a review from loleg March 22, 2021 07:53
Copy link
Contributor

@loleg loleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - here's a quick screenshot from a test server:

Screenshot from 2021-03-22 11-03-07

@loleg
Copy link
Contributor

loleg commented Mar 22, 2021

Side note, while we're on this topic, I notice that only the image of the logo is shown in the template. For accessibility reasons it would be good if the "Your logo here" translation was applied in the title attribute, or at least something like "Back to home". We can come back to this later. cc @VivienFuhrer

See FrontendNavbar.vue

@loleg loleg closed this Mar 22, 2021
@loleg loleg reopened this Mar 22, 2021
@loleg loleg merged commit bc73a53 into ProxeusApp:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants