Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve go dev build issue #198

Merged
merged 13 commits into from
Dec 18, 2020
Merged

Resolve go dev build issue #198

merged 13 commits into from
Dec 18, 2020

Conversation

loleg
Copy link
Contributor

@loleg loleg commented Dec 18, 2020

Fix to a minor issue preventing the go build from completing: instead of the asticode version we are now using the actively maintained go-bindata fork. This resolves #197

Adds a make update command which will upgrade all Go packages.

The 'stable' release of Debian will be used for Docker instead of the now aged 'stretch' release.

Additionally, this PR includes an upgrade of yarn packages and some tweaks to documentation.

@loleg loleg requested a review from notfabian December 18, 2020 12:16
Copy link

@notfabian notfabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking me to have a look at this. It looks plausible. Disclaimer: I didn't test it.

@loleg loleg merged commit 6363d5f into ProxeusApp:master Dec 18, 2020
@loleg
Copy link
Contributor Author

loleg commented Dec 18, 2020

This release has been deployed and tested on a new machine. We can do more testing after upgrading the demo instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-bindata not found
2 participants