Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email from doesn't get picked up #175

Open
ianaz opened this issue Apr 17, 2020 · 1 comment
Open

Email from doesn't get picked up #175

ianaz opened this issue Apr 17, 2020 · 1 comment
Labels
backend Pull requests that update Go code bounty There is a bounty attached to this issue!

Comments

@ianaz
Copy link
Contributor

ianaz commented Apr 17, 2020

Subject of the issue

Looks like PROXEUS_EMAIL_FROM parameter doesn't get picked up by the application

Your environment

Linux 19.10 (Eoan Ermine)

Steps to reproduce

Setting the environment variable PROXEUS_EMAIL_FROM in my system doesn't seem to affect the variable in code. Emails will still be sent by the default value ([email protected]), unless you change them manually in settings

Expected behaviour

PROXEUS_EMAIL_FROM should set the sending email address correctly

@loleg
Copy link
Contributor

loleg commented Dec 18, 2020

I can confirm this to be the case, and think we might need to make the actual fix in https://github.com/ProxeusApp/node-mail-sender

@loleg loleg added $100 bounty There is a bounty attached to this issue! labels Jan 21, 2021
@loleg loleg removed the $100 label Apr 30, 2021
loleg pushed a commit that referenced this issue Nov 4, 2021
…problem (#229)

* Fix email from mismatch between env and settings db (#175)

* Encrypt Infura and SparkPost API keys inside the databse (#1)

* updated websocket package version to solve the go sum checksum mismatch problem

* Add golang.org/x/tools to go.sum by go mod download

* Modify dependencies to fix go.sum

* Modify go.sum

* Modify go.sum

* Modify go.sum

* Fix tests dependency problem

* Add encryption secret key to the Makefile

* change the encryption secret key in makefile
loleg added a commit that referenced this issue Nov 4, 2021
* Refactored start docs

* Changed source of go-bindata #197

* Updated go dep trackers

* Updated yarn dependencies

* Added update step to Makefile

* New auto-generated bindata tests

* Added doc note about make update

* yarn upgrade

* Doc: rename Infura key as "project ID" for clarity

* Set resource class to medium for CircleCI builds

* Use Debian 'stable' release in Docker

* Add .env configuration loader to make #204

* Copy env during bootstrap

* Documentation related to license finder

* go-bindata install path

* Docker documentation link

* README revised

* Added logging instruction

* Revert go-ethereum v1.9.25

* Detect window.ethereum (#203)

* mod clean

* Updated minor go dependencies

* Fix email from mismatch between env and settings db (#175)

* Encrypt Infura and SparkPost API keys inside the databse (#1)

* updated websocket package version to solve the go sum checksum mismatch problem

* Add golang.org/x/tools to go.sum by go mod download

* Modify dependencies to fix go.sum

* Modify go.sum

* Modify go.sum

* Modify go.sum

* Fix tests dependency problem

* Add encryption secret key to the Makefile

* Fix go mod tools loading and pin fasthttp/websocket version

* go.sum check

* Added documentation on PROXEUS_ENCRYPTION_SECRET_KEY

Co-authored-by: Mehdy javany <[email protected]>
Co-authored-by: javany <[email protected]>
@loleg loleg added the backend Pull requests that update Go code label Jan 5, 2022
@loleg loleg moved this to Todo in Maintenance - Q1 2024 Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Pull requests that update Go code bounty There is a bounty attached to this issue!
Projects
Development

No branches or pull requests

2 participants