Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section header disappearing fix for tvOS from #2033 #2038

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Section header disappearing fix for tvOS from #2033 #2038

merged 1 commit into from
Dec 3, 2022

Conversation

mrjschulte
Copy link
Collaborator

Propagates @dnicolson's #2033 fix for the Section headers disappearing to tvOS as well. Tested and works.

@mrjschulte
Update PVGameLibrarySectionHeaderView.swift
613648a 
Propagates @dnicolson's #2033 fix for the Section headers disappearing to tvOS as well.
@mrjschulte mrjschulte added tvOS isolated to tvOS only (unless like tag is paired) design design, graphics, UI/UX… Apple TV4K+ Apple TV4K and up… (no USB) Apple TV4 Apple TV4 (has USB) labels Dec 3, 2022
@mrjschulte mrjschulte added this to the 2.1.2 milestone Dec 3, 2022
@mrjschulte mrjschulte changed the title Update PVGameLibrarySectionHeaderView.swift Section header disappearing fix for tvOS from #2033 Dec 3, 2022
@ghost
Copy link

ghost commented Dec 3, 2022

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@JoeMatt JoeMatt merged commit 2024a49 into develop Dec 3, 2022
@JoeMatt JoeMatt deleted the mrjschulte_section_header_fix_tvOS branch December 6, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeMatt JoeMatt JoeMatt approved these changes

@jasarien jasarien Awaiting requested review from jasarien jasarien is a code owner

Assignees
No one assigned
Labels
Apple TV4K+ Apple TV4K and up… (no USB) Apple TV4 Apple TV4 (has USB) design design, graphics, UI/UX… tvOS isolated to tvOS only (unless like tag is paired)
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mrjschulte @JoeMatt