Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PVGameMoreInfoViewController.swift - tvOS usability and Back of the Box support. #2029

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

mrjschulte
Copy link
Collaborator

tvOS Only - This allows the user to use a double click on the controller/remote to view the Back of the Box artwork when in the GameInfo view.

This PR also removes the scrolling/editing options and sets the Game Description Text to a fixed 24 System Font for better readability without having to scroll when viewing large bodies of text.

@mrjschulte mrjschulte added enhancement improvements, enhancements, new features, additions ui/ux related to user interface and experience tvOS isolated to tvOS only (unless like tag is paired) design design, graphics, UI/UX… Apple TV4K+ Apple TV4K and up… (no USB) Apple TV4 Apple TV4 (has USB) labels Nov 27, 2022
@mrjschulte mrjschulte added this to the 2.1.2 milestone Nov 27, 2022
@mrjschulte mrjschulte self-assigned this Nov 27, 2022
@ghost
Copy link

ghost commented Nov 27, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

tvOS Only - This allows the user to use a double click on the controller/remote to view the Back of the Box artwork when in the GameInfo view. 
This also removes the scrolling option and sets the Game Description Text to a fixed 24 System Font for better readability without having to scroll.
@JoeMatt JoeMatt merged commit 5e7cc6b into develop Nov 28, 2022
@JoeMatt JoeMatt deleted the tvOS-GameInfo-Tweaks branch November 28, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apple TV4K+ Apple TV4K and up… (no USB) Apple TV4 Apple TV4 (has USB) design design, graphics, UI/UX… enhancement improvements, enhancements, new features, additions tvOS isolated to tvOS only (unless like tag is paired) ui/ux related to user interface and experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants