Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tint after using the cancel action when selecting a controller #1999

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Fix tint after using the cancel action when selecting a controller #1999

merged 1 commit into from
Nov 21, 2022

Conversation

dnicolson
Copy link
Contributor

What does this PR do

This pull request prevents dismissing the modal without making a selection which leaves the cell with a tint. Dismissing the modal or selecting "Not Playing" also has the same effect.

Copy link
Member

@JoeMatt JoeMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just deletes it?
Is there another part that does the cancel?

@dnicolson
Copy link
Contributor Author

Yeah, with this action the user can dismiss the modal by tapping outside of it.

@jasarien
Copy link
Member

What about when using a controller?

@JoeMatt JoeMatt self-assigned this Nov 12, 2022
@JoeMatt JoeMatt added this to the 2.1.2 milestone Nov 12, 2022
@dnicolson
Copy link
Contributor Author

The behavior does not change when using a controller.

@JoeMatt JoeMatt force-pushed the develop branch 2 times, most recently from a789cf0 to f0c3e73 Compare November 13, 2022 00:51
@JoeMatt JoeMatt merged commit 8aa67f9 into Provenance-Emu:develop Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants