Address some comments in #377 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendyarm
reviewed
Jul 28, 2024
There was a problem hiding this comment.
I noticed you changed ### Mapping to ### Mappings.
I think that change looks good, but there are many other headings
that could be pluralized to make it look more consistent.
Array and Tuple are the most obvious.
Arrays and Tuples would be good.
However, it doesn't read as well to change some of them,
like this would be harder to read: ### Asserts and AssertEqs,
so I wouldn't change that one.
Co-authored-by: Eric McCarthy <[email protected]> Signed-off-by: d0cd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^