[Perf] Introduce MulAssign for LinearCombination #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from AleoNet#2460; just to recap, this PR improves the performance (both CPU and heap) of
Poseidon::hash_many
which is prominent in heap profiles, and it consists of 2 changes:MulAssign<&F> for LinearCombination<F>
, so thatMulAssign<&Field<E>> for Field<E>
can avoid going throughMul<&F> for &LinearCombination<F>
(which clones theLinearCombination
); a relevant benchmark is added tooPoseidon::hash_many
via direct tweaks to allocationsThese changes reduce the number of allocs/s in a node during a large deployment+execution by ~6% and speeds up the
MulAssign<&Field<E>> for Field<E>
operation by ~33%: