Merge pull request #1950 from zhiqiangxu/fix_check_output

Fix mutability of `check_output` and `check_instruction_opcode`
ProvableHQ · Sep 1, 2023 · b87eb05 · b87eb05 · github-actions · Sep 1, 2023
2 parents bba855f + 25a61cf
commit b87eb05
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/algorithms/src/fft/domain.rs b/algorithms/src/fft/domain.rs
@@ -92,7 +92,7 @@ pub struct EvaluationDomain<F: FftField> {
     pub group_gen: F,
     /// Inverse of the generator of the subgroup.
     pub group_gen_inv: F,
-    /// Multiplicative generator of the finite field.
+    /// Inverse of the multiplicative generator of the finite field.
     pub generator_inv: F,
 }
 

diff --git a/synthesizer/process/src/stack/register_types/initialize.rs b/synthesizer/process/src/stack/register_types/initialize.rs
@@ -222,7 +222,7 @@ impl<N: Network> RegisterTypes<N> {
     /// Ensure the given output register is well-formed.
     #[inline]
     fn check_output(
-        &mut self,
+        &self,
         stack: &(impl StackMatches<N> + StackProgram<N>),
         operand: &Operand<N>,
         register_type: &RegisterType<N>,
@@ -312,7 +312,7 @@ impl<N: Network> RegisterTypes<N> {
     /// This method is called when adding a new closure or function to the program.
     #[inline]
     fn check_instruction_opcode(
-        &mut self,
+        &self,
         stack: &(impl StackMatches<N> + StackProgram<N>),
         closure_or_function_name: &Identifier<N>,
         instruction: &Instruction<N>,
Benchmark suite	Current: `b87eb05`	Previous: `b9d521c`	Ratio
`bls12_377: fq2_add_assign`	`49` ns/iter (`± 0`)	`28` ns/iter (`± 0`)	`1.75`
`bls12_377: fq2_sub_assign`	`31` ns/iter (`± 0`)	`17` ns/iter (`± 0`)	`1.82`
`bls12_377: fq2_double`	`42` ns/iter (`± 0`)	`24` ns/iter (`± 0`)	`1.75`