Pass Circuit by reference #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=======================================
Coverage 78.86% 78.86%
=======================================
Files 353 353
Lines 22296 22302 +6
=======================================
+ Hits 17583 17589 +6
Misses 4713 4713
Continue to review full report at Codecov.
|
Signed-off-by: ljedrz <[email protected]>
ljedrz
force-pushed
the
ref_circuit_args
branch
from
3f23c48 to
45d4792
Compare
|
Rebased. |
howardwu
approved these changes
Oct 23, 2020
|
LGTM! |
Raphexion
added a commit
to eigerco/snarkOS
that referenced
this pull request
Dec 3, 2024
When prometheus updates to v3, it is becoming stricter with the Content-Type of the response. https://prometheus.io/docs/prometheus/3.0/migration/#scrape-protocols ``` Prometheus v3 is more strict concerning the Content-Type header received when scraping. Prometheus v2 would default to the standard Prometheus text protocol if the target being scraped did not specify a Content-Type header or if the header was unparsable or unrecognised. This could lead to incorrect data being parsed in the scrape. Prometheus v3 will now fail the scrape in such cases. ``` The Content-Type is updated in dependency. So all we have to do is update the version. From the metrics/metrics-exporter-prometheus CHANGELOG.md: ``` - Update the `Content-Type` response header to `text/plain`, matching the Exposition format specification. ([ProvableHQ#496](metrics-rs/metrics#496)) ```
Raphexion
added a commit
to eigerco/snarkOS
that referenced
this pull request
Dec 18, 2024
When prometheus updates to v3, it is becoming stricter with the Content-Type of the response. https://prometheus.io/docs/prometheus/3.0/migration/#scrape-protocols ``` Prometheus v3 is more strict concerning the Content-Type header received when scraping. Prometheus v2 would default to the standard Prometheus text protocol if the target being scraped did not specify a Content-Type header or if the header was unparsable or unrecognised. This could lead to incorrect data being parsed in the scrape. Prometheus v3 will now fail the scrape in such cases. ``` The Content-Type is updated in dependency. So all we have to do is update the version. From the metrics/metrics-exporter-prometheus CHANGELOG.md: ``` - Update the `Content-Type` response header to `text/plain`, matching the Exposition format specification. ([ProvableHQ#496](metrics-rs/metrics#496)) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow Leo
Programs to not require costly cloning during the build process and remove the need to deriveClonefor them and the related objects that are not practical to clone.