Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subcommand help messages #1563

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Fix subcommand help messages #1563

merged 2 commits into from
Feb 2, 2022

Conversation

rapiz1
Copy link

@rapiz1 rapiz1 commented Jan 24, 2022

Motivation

Fixes #1562

It's a upstream bug. See TeXitoi/structopt#333

Test Plan

Run leo -h and see if it works

After the fix:

leo 1.5.3
The Aleo Team <[email protected]>
Leo compiler and package manager

USAGE:
    leo [FLAGS] [OPTIONS] [api] <SUBCOMMAND>

FLAGS:
    -d               Print additional information for debugging
    -h, --help       Prints help information
    -q               Suppress CLI output
    -V, --version    Prints version information

OPTIONS:
        --path <path>    Optional path to Leo program root folder

ARGS:
    <api>    Custom Aleo PM backend URL [env: APM_URL=]

SUBCOMMANDS:
    build      Compile and build program command
    clean      Clean outputs folder command
    clone      Clone a package from Aleo Package Manager
    deploy     Deploy Leo program to the network
    fetch      Pull dependencies specified in Leo toml
    help       Prints this message or the help of the given subcommand(s)
    init       Init Leo project command within current directory
    lint       Lint Leo code command
    login      Login to Aleo PM and store credentials locally
    logout     Remove credentials for Aleo PM from .leo directory
    new        Create new Leo project
    prove      Run the program and produce a proof
    publish    Publish package to Aleo Package Manager
    run        Build, Prove and Run Leo program with inputs
    setup      Executes the setup command for a Leo program
    test       Build program and run tests command
    update     Setting for automatic updates of Leo
    watch      Watch file changes in src/ directory and run Build Command

Help messages are good now! :)

Copy link
Contributor

@damirka damirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing!

@damirka damirka requested review from Centril, gluax and acoglio January 24, 2022 10:01
@damirka
Copy link
Contributor

damirka commented Jan 24, 2022

@acoglio these three checks related to APM won't pass because the PR was created by a non-team developer, and the CIs don't have permissions to access CI secrets.

@gluax gluax requested a review from collinc97 January 24, 2022 17:53
@acoglio
Copy link
Collaborator

acoglio commented Jan 25, 2022

@damirka If someone from our team can double-check that those failing CI tests work for him, I think we are fine.

@rapiz1
Copy link
Author

rapiz1 commented Jan 25, 2022

Should I retarget it onto staging?

@gluax
Copy link
Contributor

gluax commented Jan 25, 2022

@rapiz1 that would be helpful!

@rapiz1 rapiz1 changed the base branch from master to staging January 26, 2022 03:45
@rapiz1
Copy link
Author

rapiz1 commented Jan 26, 2022

Done that

@gluax gluax merged commit 77b2b92 into ProvableHQ:staging Feb 2, 2022
@rapiz1 rapiz1 deleted the help-fix branch February 7, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] subcommand help message is broken
5 participants