Clippy

ProvableHQ · Apr 2, 2024 · 26dba19 · 26dba19
1 parent f6fde0d
commit 26dba19
Show file tree

Hide file tree

Showing 4 changed files with 899 additions and 70 deletions.
diff --git a/compiler/ast/src/value/mod.rs b/compiler/ast/src/value/mod.rs
@@ -765,20 +765,12 @@ impl TryFrom<&Value> for i128 {
     fn try_from(value: &Value) -> Result<Self, Self::Error> {
         use Value::*;
         match value {
-            U8(val, span) => {
-                i128::try_from(*val).map_err(|_| FlattenError::loop_has_neg_value(Type::from(value), *span).into())
-            }
-            U16(val, span) => {
-                i128::try_from(*val).map_err(|_| FlattenError::loop_has_neg_value(Type::from(value), *span).into())
-            }
-            U32(val, span) => {
-                i128::try_from(*val).map_err(|_| FlattenError::loop_has_neg_value(Type::from(value), *span).into())
-            }
-            U64(val, span) => {
-                i128::try_from(*val).map_err(|_| FlattenError::loop_has_neg_value(Type::from(value), *span).into())
-            }
+            U8(val, _) => Ok(*val as i128),
+            U16(val, _) => Ok(*val as i128),
+            U32(val, _) => Ok(*val as i128),
+            U64(val, _) => Ok(*val as i128),
             U128(val, span) => {
-                i128::try_from(*val).map_err(|_| FlattenError::loop_has_neg_value(Type::from(value), *span).into())
+                i128::try_from(*val).map_err(|_| FlattenError::u128_to_i128(Type::from(value), *span).into())
             }
             I8(val, _) => Ok(*val as i128),
             I16(val, _) => Ok(*val as i128),

diff --git a/errors/src/errors/flattener/flattener_errors.rs b/errors/src/errors/flattener/flattener_errors.rs
@@ -53,4 +53,14 @@ create_messages!(
         ),
         help: None,
     }
+
+    /// For when a u128 value cannot be converted into an i128.
+    @formatted
+    u128_to_i128 {
+        args: (value: impl Display),
+        msg: format!(
+            "The value `{value}` cannot be converted into an i128.",
+        ),
+        help: None,
+    }
 );