validation rule for RFC5322 headers From and Sender is too strict

[pengux]

The check for value in From and Sender header at

gluon/rfc5322/validation.go

Line 66 in a9327fb

if len(senderAddr) == 1 && senderAddr[0].Address == addresses[0].Address {

seems too strict as the specification doesn't mention that the values in the fields cannot be the same. Furthermore, it is common for email messages to have different names in the fields but with the same email addresses such as:

From: "John Doe via Service" <[email protected]>
Sender: "Service" <[email protected]>

The check should either be removed or perhaps modified so it takes into consideration the equality of the names too.

[LBeernaertProton]

Hey @pengux. Thank you for the report and for bringing this up. We have internally tracked this as GODT-2776.

[pengux]

@LBeernaertProton Thanks! I've also investigated a bit more and there are many email messages that also have the same name values in both headers, so modifying the rule won't help. Only removing it would allow those emails to be accepted.

[github-actions]

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀