Not respecting rfc3501 (imap4rev1) for ABNF syntaxe

[PhilipRotz]

Hi ! And first of all, thank you for your work 🚀

I'm using gluon server with a client that only follows IMAP4rev1 RFC, and I got an error while parsing a gluon IMAP response, as it does not follow the ABNF syntaxe everywhere

Here is the steps to reproduce :

>> telnet 127.0.0.1 1143
a0 login [email protected] pass
...
a5 UID SEARCH ALL
* SEARCH 6 7
a5 OK command completed in 337.51µs

As you can see, the server took "337.51µs" to respond... "µs" -> here is the problem, "µ" is not an ASCII char.
As defined in rfc3501 (IMAP4rev1 that Gluon tends to follow), IMAP syntaxe should follow ABNF.
Quote from rfc3501:

resp-cond-state = ("OK" / "NO" / "BAD") SP resp-text
resp-text = ["[" resp-text-code "]" SP] text
text = 1*TEXT-CHAR
TEXT-CHAR = any CHAR except CR and LF

and the ABNF rfc5234 tells that CHAR are only US-ASCII

CHAR = %x01-7F
; any 7-bit US-ASCII character,
; excluding NUL

"µ" char is not in this range (as it is UTF-8)

The problem is located here :

gluon/internal/session/context.go

Lines 22 to 28 in aa59753

	func okMessage(ctx context.Context) string {
	if startTime, ok := startTimeFromContext(ctx); ok {
	return fmt.Sprintf("command completed in %v", time.Since(startTime))
	}
	return ""
	}

I think this should be fixed to follow rfc3501

Thank you !!

[LBeernaertProton]

Hey @PhilipRotz, thanks for the report. That's indeed an oversight on our part. We'll fix this as soon as we have time.

[github-actions]

🎉 This issue has been resolved in version 0.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀