fix(GODT-1593): list of capabilities based on state. (#98)

* fix: passphrase for demo store.
* fix(GODT-1593): list of capabilities based on state.

imap/capabilities.go

@@ -10,3 +10,14 @@ const (
 	UIDPLUS   Capability = `UIDPLUS`
 	MOVE      Capability = `MOVE`
 )
+
+func IsCapabilityAvailableBeforeAuth(c Capability) bool {
+	switch c {
+	case IMAP4rev1, StartTLS, IDLE:
+		return true
+	case UNSELECT, UIDPLUS, MOVE:
+		return false
+	}
+
+	return false
+}

internal/session/handle_capability.go

@@ -3,15 +3,34 @@ package session
 import (
 	"context"
 
+	"github.com/ProtonMail/gluon/imap"
 	"github.com/ProtonMail/gluon/internal/parser/proto"
 	"github.com/ProtonMail/gluon/internal/response"
 )
 
+func (s *Session) getCaps() []imap.Capability {
+	s.userLock.Lock()
+	defer s.userLock.Unlock()
+
+	if s.state != nil {
+		return s.caps
+	}
+
+	caps := []imap.Capability{}
+	for _, c := range s.caps {
+		if imap.IsCapabilityAvailableBeforeAuth(c) {
+			caps = append(caps, c)
+		}
+	}
+
+	return caps
+}
+
 func (s *Session) handleCapability(ctx context.Context, tag string, cmd *proto.Capability, ch chan response.Response) error {
 	s.capsLock.Lock()
 	defer s.capsLock.Unlock()
 
-	ch <- response.Capability().WithCapabilities(s.caps...)
+	ch <- response.Capability().WithCapabilities(s.getCaps()...)
 
 	ch <- response.Ok(tag).WithMessage("CAPABILITY")
 

store/badger.go

@@ -1,6 +1,7 @@
 package store
 
 import (
+	"crypto/sha256"
 	"path/filepath"
 	"sync"
 	"time"
@@ -21,9 +22,11 @@ type badgerTransaction struct {
 }
 
 func NewBadgerStore(path string, userID string, encryptionPassphrase []byte) (*BadgerStore, error) {
+	encryptionKey := sha256.Sum256(encryptionPassphrase)
+
 	db, err := badger.Open(badger.DefaultOptions(filepath.Join(path, userID)).
 		WithLogger(logrus.StandardLogger()).
-		WithEncryptionKey(encryptionPassphrase).
+		WithEncryptionKey(encryptionKey[:]).
 		WithIndexCacheSize(128 * 1024 * 1024),
 	)
 	if err != nil {

tests/capability_test.go

@@ -2,24 +2,19 @@ package tests
 
 import (
 	"testing"
-
-	"github.com/ProtonMail/gluon/imap"
-	"github.com/emersion/go-imap/client"
-	"github.com/stretchr/testify/require"
-	"golang.org/x/exp/maps"
 )
 
 func TestCapability(t *testing.T) {
-	runOneToOneTestClient(t, defaultServerOptions(t), func(client *client.Client, s *testSession) {
-		capabilities, err := client.Capability()
-		require.NoError(t, err)
-		require.ElementsMatch(t, maps.Keys(capabilities), []string{
-			string(imap.IMAP4rev1),
-			string(imap.StartTLS),
-			string(imap.IDLE),
-			string(imap.UNSELECT),
-			string(imap.UIDPLUS),
-			string(imap.MOVE),
-		})
+	runOneToOneTest(t, defaultServerOptions(t), func(c *testConnection, _ *testSession) {
+		c.C("A001 Capability")
+		c.S(`* CAPABILITY IDLE IMAP4rev1 STARTTLS`)
+		c.S("A001 OK")
+
+		c.C(`A002 login "user" "pass"`)
+		c.S(`A002 OK [CAPABILITY IDLE IMAP4rev1 MOVE STARTTLS UIDPLUS UNSELECT]`)
+
+		c.C("A003 Capability")
+		c.S(`* CAPABILITY IDLE IMAP4rev1 MOVE STARTTLS UIDPLUS UNSELECT`)
+		c.S("A003 OK")
 	})
 }