fix(GODT-2649): Clean up cache files if connector create message fails

Cleanup cache files we generate when creating messages from the
connector if the db transaction was not committed successfully.

internal/backend/connector_updates.go

@@ -5,6 +5,7 @@ import (
 	"context"
 	"fmt"
 	"io"
+	"os"
 	"runtime"
 	"strings"
 
@@ -214,7 +215,7 @@ func (user *user) applyMessagesCreated(ctx context.Context, update *imap.Message
 	messageForMBox := make(map[imap.InternalMailboxID][]imap.InternalMessageID)
 	mboxInternalIDMap := make(map[imap.MailboxID]imap.InternalMailboxID)
 
-	return user.db.Write(ctx, func(ctx context.Context, tx *ent.Tx) error {
+	err := user.db.Write(ctx, func(ctx context.Context, tx *ent.Tx) error {
 		client := tx.Client()
 
 		for _, message := range update.Messages {
@@ -336,6 +337,19 @@ func (user *user) applyMessagesCreated(ctx context.Context, update *imap.Message
 
 		return nil
 	})
+
+	// Clean up cache messages that were created if the transaction failed.
+	if err != nil {
+		for _, message := range messagesToCreate {
+			if err := user.store.DeleteUnchecked(message.InternalID); err != nil {
+				if !os.IsNotExist(err) {
+					logrus.WithError(err).Errorf("Failed to delete cache message %v after failed transaction", message.InternalID)
+				}
+			}
+		}
+	}
+
+	return err
 }
 
 // applyMessageMailboxesUpdated applies a MessageMailboxesUpdated update.

store/write_controlled_store.go

@@ -95,6 +95,12 @@ func (w *WriteControlledStore) SetUnchecked(messageID imap.InternalMessageID, re
 	return w.impl.Set(messageID, reader)
 }
 
+// DeleteUnchecked allows the user to bypass lock access. This will only work if you can guarantee that the data being
+// delete is not being used anywhere.
+func (w *WriteControlledStore) DeleteUnchecked(messageIDs ...imap.InternalMessageID) error {
+	return w.impl.Delete(messageIDs...)
+}
+
 func (w *WriteControlledStore) Delete(messageID ...imap.InternalMessageID) error {
 	for _, id := range messageID {
 		if err := func() error {