Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update useful concepts positioning #225

Merged
merged 3 commits into from
Jun 17, 2019

Conversation

fsdiogo
Copy link
Collaborator

@fsdiogo fsdiogo commented May 14, 2019

Reposition the Useful Concepts box as it was taking a lot of horizontal space from the lesson:

old new
old new

@fsdiogo fsdiogo self-assigned this May 14, 2019
@olizilla
Copy link
Collaborator

I deliberately pulled out the Useful Concepts box as aside to add a little visual interest, and as the lesson text discusses new concepts, it seemed better to pull the box up near the top, so they can see there is a glossary for those terms.

That said, it looks neat in the example... but perhaps it should just be explained in the body text of the lesson before the term is first used, rather than in a seperate box.

@terichadbourne
Copy link
Member

I agree with @olizilla that if it’s going to be used it should be an aside visible from the top, not moved to the bottom. However, we could try wrapping the main text so that we’re only losing the right side of the screen until the bottom of the concepts box and then the main text flows all the way to the right again. That would be my proposal for right now.

See the proposal here for an in-line glossary feature (which we don’t have time to prioritize right now): #99

If we all agree that we don’t want the box used long term, we could remove the option from the instructions for building new tutorials and open an issue (to ignore until after camp) to go back and rewrite existing lessons that use it so they either define terms in line or link to external resources like the decentralized data structure tutorial.

@fsdiogo
Copy link
Collaborator Author

fsdiogo commented May 14, 2019

What if we put it under the title?

1

@terichadbourne
Copy link
Member

@fsdiogo I like your suggestion of putting it at the top, but only for mobile with a very narrow screen. When the space is available, my own preference would be to leave it as an aside at the top right (visible from the top but without any suggestion that it's the main content) and fix the wrapping so that the main content can take up the full width of the screen once it's under the aside (old-school float style). I also think the top of the useful concepts box should be under the lesson title, not aligned with it. Here's a shoddily copy-and-pasted mockup of what I'd envision for when the real estate allows:
image

@fsdiogo
Copy link
Collaborator Author

fsdiogo commented Jun 14, 2019

I like your suggestion @terichadbourne 👍

My last commit addresses everything:

Desktop Mobile
desktop mobile

What do you think?

@terichadbourne
Copy link
Member

Looks great @fsdiogo. Thank you!

@terichadbourne terichadbourne merged commit 327525d into code Jun 17, 2019
@terichadbourne terichadbourne deleted the chore/update-concepts-positioning branch June 17, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants