Fix "Bad bounding indices" error on invalid _CoqProject #708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #707.
The first commit is purely the bugfix. (Note: I didn't understand the previous code, as I am no Elisp expert, maybe it is doing something really important besides producing very obscure failure modes?)
The second commit turns
warn
intomessage
. When testing with only the first commit I did not manage to see thewarn
string anywhere on my Emacs, so the error is a bit too silent to my taste. (We are noticing that the user _CoqProject is broken and just silently ignoring it.)message
is slightly better. I wonder iferror
wouldn't be even better, but the current code logic is to be resilient and ignore the error, so I kept that.