Omit let fix #696
Merged
Omit let fix #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendriktews
force-pushed
the
omit-let-fix
branch
from
e65aaba to
27cc903
Compare
hendriktews
force-pushed
the
omit-let-fix
branch
from
4f666f1 to
557e4ac
Compare
hendriktews
force-pushed
the
omit-let-fix
branch
from
557e4ac to
cf80d2c
Compare
|
Similar to #694 , I suggest to merge this PR as is. |
|
Sorry I don't have time to review precisely but it seems ok to me. The mechanics for detecting effectfull commands and proofs is a good idea. Once again if we were using the modern protocols for communicating with coq, coq itself would give this information... |
Add support for recognizing proof-script commands that prevent the omission of proofs that follow them directly, such as a Let declaration with a proof script in Coq. Fixes ProofGeneral#687
hendriktews
force-pushed
the
omit-let-fix
branch
from
cf80d2c to
ac6f65c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.