Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make CI pass #109

Merged
merged 1 commit into from
Jan 31, 2023
Merged

ci: make CI pass #109

merged 1 commit into from
Jan 31, 2023

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jan 30, 2023

  • rework phpstan
  • check multiple php versions
  • fix errors

Signed-off-by: Simon Podlipsky [email protected]

#99 broke CI, this aims to fix it since all other PRs now fail which is irrelevant to them.

@simPod simPod force-pushed the ci branch 9 times, most recently from 5cb0571 to 264ed98 Compare January 30, 2023 13:18
@simPod
ci: make CI pass
cb34851 
- rework phpstan
- check multiple php versions
- fix errors

Signed-off-by: Simon Podlipsky <[email protected]>
@simPod simPod marked this pull request as ready for review January 30, 2023 13:39
@simPod
Copy link
Contributor Author

simPod commented Jan 30, 2023

Also we should unmark

P7.2 - prefer-stable - ubuntu-latest
P7.3 - prefer-stable - ubuntu-latest

as required checks

@LKaemmerling
Copy link
Member

Thank you!

@LKaemmerling LKaemmerling merged commit 763a2bc into PromPHP:main Jan 31, 2023
@simPod simPod deleted the ci branch January 31, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKaemmerling LKaemmerling LKaemmerling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simPod @LKaemmerling