Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve code readability and error handling #207

Merged
merged 3 commits into from
Dec 12, 2024

feat: implement public layout and unify error handling for improved u…

30c692e
Select commit
Loading
Failed to load commit list.
Merged

refactor: improve code readability and error handling #207

feat: implement public layout and unify error handling for improved u…
30c692e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2024 in 0s

5.09% (+0.02%) compared to a27af57

View this Pull Request on Codecov

5.09% (+0.02%) compared to a27af57

Details

Codecov Report

Attention: Patch coverage is 0% with 204 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/src/app/Layouts/PublicLayout.php 0.00% 16 Missing ⚠️
app/src/app/Views/Admin/Incidence/Create.php 0.00% 15 Missing ⚠️
app/src/app/Layouts/Admin/AdminLayout.php 0.00% 14 Missing ⚠️
app/src/app/Layouts/Admin/AdminInventoryLayout.php 0.00% 13 Missing ⚠️
app/src/app/Views/Admin/ElementTypes.php 0.00% 13 Missing ⚠️
app/src/app/Core/Router.php 0.00% 10 Missing ⚠️
app/src/app/Views/Admin/Contracts.php 0.00% 10 Missing ⚠️
app/src/app/Views/Admin/Users.php 0.00% 10 Missing ⚠️
app/src/app/Views/Admin/User/Edit.php 0.00% 9 Missing ⚠️
app/src/app/Views/Admin/WorkOrders.php 0.00% 8 Missing ⚠️
... and 20 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              main    #207      +/-   ##
==========================================
+ Coverage     5.07%   5.09%   +0.02%     
+ Complexity     278     277       -1     
==========================================
  Files           92      92              
  Lines         2660    2648      -12     
==========================================
  Hits           135     135              
+ Misses        2525    2513      -12
Files with missing lines Coverage Δ Complexity Δ
app/src/app/Layouts/BlankLayout.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/Dashboard.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Error.php 0.00% <0.00%> (ø) 0.00 <0.00> (?)
app/src/app/Layouts/Customer/CustomerLayout.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/ElementType/Edit.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/TaskType/Edit.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Layouts/AuthLayout.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/Element/Create.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/TaskTypes.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/TreeType/Edit.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 20 more
View more details on Codecov