Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layouts): enhance app layouts #205

Merged

Conversation

CODEmartigarcia
Copy link
Contributor

@CODEmartigarcia CODEmartigarcia commented Dec 12, 2024

This pull request includes multiple changes aimed at enhancing the functionality and performance of the application. The most significant changes include adding Sentry for error tracking, creating a new InventoryController, and updating the AdminLayout for improved user experience.

Enhancements and New Features:

  • Error Tracking:

    • Added Sentry integration to app/composer.json and app/src/app/Core/Logger.php for better error tracking and monitoring. [1] [2]
  • New Controller:

    • Created InventoryController to manage inventory-related data and render the inventory dashboard.

Codebase Improvements:

  • Filtering Enhancements:

    • Updated BaseModel::findAll to handle NOT NULL and NULL conditions in filters, improving query flexibility. [1] [2]
  • Controller Updates:

    • Modified ElementController and ZoneController to use the enhanced findAll method with NOT NULL filters for better data retrieval. [1] [2] [3]

User Interface Improvements:

  • Admin Layout:

    • Significant updates to AdminLayout.php to include a responsive navigation bar, user info dropdown, and improved submenu for better user experience. [1] [2]
  • Title Formatting:

    • Simplified title formatting in CustomerLayout.php for consistency.

@CODEmartigarcia CODEmartigarcia requested a review from a team as a code owner December 12, 2024 14:31
@github-actions github-actions bot added kind/feature Categorizes issue or PR as related to a new feature. area/app/views Categorizes issue or PR as related to app/views. area/app/models Categorizes issue or PR as related to app/models. area/app/controllers Categorizes issue or PR as related to app/controllers. area/docker Categorizes issue or PR as related to docker. area/routes Categorizes issue or PR as related to routes or router. kind/dependencies Categorizes issue or PR as related to dependencies. area/javascript Categorizes issue or PR as related to JavaScript. labels Dec 12, 2024
@0x1026 0x1026 changed the title Feat/135-enhance-application-layouts-new-designs-and-responsiveness feat(layouts): enhance app layouts Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 132 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/src/app/Layouts/Admin/AdminLayout.php 0.00% 54 Missing ⚠️
app/src/app/Views/Admin/Contracts.php 0.00% 18 Missing ⚠️
.../src/app/Controllers/Admin/InventoryController.php 0.00% 16 Missing ⚠️
app/src/app/Core/Logger.php 0.00% 9 Missing ⚠️
app/src/app/Models/BaseModel.php 0.00% 8 Missing ⚠️
app/src/app/Views/Admin/TaskTypes.php 0.00% 7 Missing ⚠️
app/src/app/Views/Admin/Zones.php 0.00% 6 Missing ⚠️
app/src/app/Views/Admin/WorkOrders.php 0.00% 4 Missing ⚠️
app/src/app/bootstrap.php 0.00% 3 Missing ⚠️
app/src/app/Controllers/Admin/ZoneController.php 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##              main    #205      +/-   ##
==========================================
- Coverage     5.15%   5.07%   -0.08%     
- Complexity     273     278       +5     
==========================================
  Files           90      92       +2     
  Lines         2620    2660      +40     
==========================================
  Hits           135     135              
- Misses        2485    2525      +40     
Files with missing lines Coverage Δ Complexity Δ
...pp/src/app/Controllers/Admin/ElementController.php 0.00% <0.00%> (ø) 6.00 <0.00> (ø)
app/src/app/Layouts/Customer/CustomerLayout.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/Inventory.php 0.00% <0.00%> (ø) 0.00 <0.00> (?)
app/src/app/Controllers/Admin/ZoneController.php 0.00% <0.00%> (ø) 6.00 <0.00> (ø)
app/src/app/Views/Admin/TaskType/Create.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/bootstrap.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/WorkOrders.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/Zones.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/TaskTypes.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/app/Models/BaseModel.php 0.00% <0.00%> (ø) 63.00 <0.00> (+5.00)
... and 4 more

@0x1026 0x1026 merged commit 35d1206 into main Dec 12, 2024
14 checks passed
@0x1026 0x1026 deleted the feat/135-enhance-application-layouts-new-designs-and-responsiveness branch December 12, 2024 14:53
@0x1026 0x1026 linked an issue Dec 17, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app/controllers Categorizes issue or PR as related to app/controllers. area/app/models Categorizes issue or PR as related to app/models. area/app/views Categorizes issue or PR as related to app/views. area/docker Categorizes issue or PR as related to docker. area/javascript Categorizes issue or PR as related to JavaScript. area/routes Categorizes issue or PR as related to routes or router. kind/dependencies Categorizes issue or PR as related to dependencies. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Fet
Development

Successfully merging this pull request may close these issues.

[Bug]: Logger fails to work due to permission issues
8 participants