-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create ElementType #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albert1413
requested review from
Ism1tha,
0x1026,
24Victor,
Chuck-D-Norris and
XavierChao
December 10, 2024 20:21
github-actions
bot
added
area/app/views
Categorizes issue or PR as related to app/views.
area/app/models
Categorizes issue or PR as related to app/models.
area/app/controllers
Categorizes issue or PR as related to app/controllers.
area/routes
Categorizes issue or PR as related to routes or router.
labels
Dec 10, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 5.75% 5.33% -0.42%
- Complexity 269 279 +10
==========================================
Files 86 91 +5
Lines 2347 2530 +183
==========================================
Hits 135 135
- Misses 2212 2395 +183
|
0x1026
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Dec 10, 2024
0x1026
requested changes
Dec 10, 2024
github-actions
bot
removed
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Dec 10, 2024
0x1026
force-pushed
the
feat-elementType
branch
from
December 10, 2024 21:57
843bb62
to
5128e76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 26 out of 26 changed files in this pull request and generated no suggestions.
Co-authored-by: Hugoo <[email protected]> Signed-off-by: albert1413 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/app/controllers
Categorizes issue or PR as related to app/controllers.
area/app/models
Categorizes issue or PR as related to app/models.
area/app/views
Categorizes issue or PR as related to app/views.
area/routes
Categorizes issue or PR as related to routes or router.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
app/src/app
directory, focusing on the addition of new fields and methods to various model classes and the creation of a new controller for managing element types.New Controller:
app/src/app/Controllers/Admin/ElementTypeController.php
: Added a new controller with methods for CRUD operations on element types.Model Updates:
app/src/app/Models/BaseModel.php
: Addedupdated_at
anddeleted_at
fields and their respective getter methods. [1] [2]app/src/app/Models/ElementType.php
: Created a new model forElementType
with fields and a method to map data to the model.Data Mapping Enhancements:
mapDataToModel
method in multiple model files to includeupdated_at
anddeleted_at
fields:Contract.php
Element.php
Incidence.php
Machine.php
Photo.php
Point.php
PruningType.php
Role.php
Route.php
Sensor.php
SensorHistory.php
Task.php
TaskType.php
TreeType.php
User.php
WorkOrder.php
WorkReport.php
Code Simplification:
app/src/app/Models/BaseModel.php
: Simplified thebulkInsert
method by combining nested loops into a single line.