Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): update image version handling and remove SENTRY_RELEASE property #196

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

0x1026
Copy link
Member

@0x1026 0x1026 commented Dec 10, 2024

This pull request includes changes to the api/src and api/tests directories to modify how the IMAGE_VERSION is handled and to remove the SENTRY_RELEASE property. The changes ensure that the IMAGE_VERSION always starts with a 'v' prefix and simplify the configuration settings.

Configuration changes:

  • api/src/config.py: Modified the check_image_version method to ensure the IMAGE_VERSION starts with a 'v' prefix. Removed the SENTRY_RELEASE property from the Settings class. [1] [2]

Usage updates:

  • api/src/main.py: Updated references to SENTRY_RELEASE to use IMAGE_VERSION instead in the Sentry initialization and health check endpoint. [1] [2]

Test adjustments:

  • api/tests/test_config.py: Removed assertions related to SENTRY_RELEASE and updated tests to reflect the new handling of IMAGE_VERSION with a 'v' prefix. [1] [2] [3]

@0x1026 0x1026 requested a review from a team as a code owner December 10, 2024 11:50
@0x1026 0x1026 merged commit 51ac647 into main Dec 10, 2024
25 checks passed
@0x1026 0x1026 deleted the fix/api-version branch December 10, 2024 11:50
@github-actions github-actions bot added kind/bug Categorizes issue or PR as related to a bug. area/api Categorizes issue or PR as related to api. area/tests Categorizes issue or PR as related to tests. labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Categorizes issue or PR as related to api. area/tests Categorizes issue or PR as related to tests. kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Fet
Development

Successfully merging this pull request may close these issues.

1 participant