Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): integrate Sentry for error tracking and monitoring #171

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

0x1026
Copy link
Member

@0x1026 0x1026 commented Dec 4, 2024

This pull request introduces several changes to integrate Sentry for error monitoring and improve environment configuration to the API. The key changes include adding Sentry DSN variables, updating Docker and FastAPI configurations, and creating tests for the new settings.

Sentry Integration:

Environment Configuration:

CI/CD Integration:

Testing:

  • api/tests/test_config.py: Added tests for the new settings, including scenarios with and without passwords and handling non-existent password files.

@0x1026 0x1026 added this to the Sprint 3 - Prototype milestone Dec 4, 2024
@github-actions github-actions bot added kind/feature Categorizes issue or PR as related to a new feature. area/api Categorizes issue or PR as related to api. area/docker Categorizes issue or PR as related to docker. kind/dependencies Categorizes issue or PR as related to dependencies. labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/src/app.py 0.00% 2 Missing ⚠️
api/src/config.py 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
api/src/config.py 94.73% <83.33%> (+94.73%) 0.00 <0.00> (ø)
api/src/app.py 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

... and 85 files with indirect coverage changes

@github-actions github-actions bot added the area/tests Categorizes issue or PR as related to tests. label Dec 4, 2024
@0x1026 0x1026 marked this pull request as ready for review December 4, 2024 03:11
@0x1026 0x1026 requested review from a team as code owners December 4, 2024 03:11
@0x1026 0x1026 changed the title feat(sentry): integrate Sentry for error tracking and monitoring feat(api): integrate Sentry for error tracking and monitoring Dec 4, 2024
@0x1026 0x1026 merged commit 517c426 into main Dec 4, 2024
10 checks passed
@0x1026 0x1026 deleted the feat/api-sentry branch December 4, 2024 09:52
@Ism1tha Ism1tha linked an issue Dec 16, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Categorizes issue or PR as related to api. area/docker Categorizes issue or PR as related to docker. area/tests Categorizes issue or PR as related to tests. kind/dependencies Categorizes issue or PR as related to dependencies. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Fet
Development

Successfully merging this pull request may close these issues.

3 participants