fix(api): normalize image version handling by removing 'v' prefix

Projecte-UrbanTree · Dec 10, 2024 · 86b4acc · 86b4acc
1 parent 7fb810e
commit 86b4acc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/api/src/config.py b/api/src/config.py
@@ -32,8 +32,8 @@ class Settings(BaseSettings):
     def check_image_version(cls, v):
         if v == "":
             return None
-        if v and not v.startswith("v"):
-            return f"v{v}"
+        if v.startswith("v"):
+            return v[1:]
         return v
 
     @model_validator(mode="before")

diff --git a/api/tests/test_config.py b/api/tests/test_config.py
@@ -29,7 +29,7 @@ def test_settings_with_custom_settings():
         APP_NAME="api",
         APP_PACKAGE="api2",
         APP_ENV="production",
-        IMAGE_VERSION="v1.0.0",
+        IMAGE_VERSION="1.0.0",
         MARIADB_SERVER="127.0.0.1",
         MARIADB_PORT=3307,
         MARIADB_USER="user2",
@@ -40,7 +40,7 @@ def test_settings_with_custom_settings():
     assert custom.APP_NAME == "api"
     assert custom.APP_PACKAGE == "api2"
     assert custom.APP_ENV == "production"
-    assert custom.IMAGE_VERSION == "v1.0.0"
+    assert custom.IMAGE_VERSION == "1.0.0"
     assert custom.MARIADB_SERVER == "127.0.0.1"
     assert custom.MARIADB_PORT == 3307
     assert custom.MARIADB_USER == "user2"
@@ -53,11 +53,11 @@ def test_settings_with_custom_settings():
     )
 
 
-def test_image_version_without_v_prefix():
+def test_image_version_wit_v_prefix():
     custom = Settings(
-        IMAGE_VERSION="1.0.0",
+        IMAGE_VERSION="v1.0.0",
     )
-    assert custom.IMAGE_VERSION == "v1.0.0"
+    assert custom.IMAGE_VERSION == "1.0.0"
 
 
 def test_settings_missing_password():