Pow #18
Merged
Pow #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babbush
reviewed
May 17, 2017
| @@ -217,11 +215,6 @@ def momentum_potential_operator(n_dimensions, grid_length, | |||
| Raises: | |||
There was a problem hiding this comment.
Get rid of this "raises" spec in the docs.
babbush
suggested changes
May 17, 2017
There was a problem hiding this comment.
Thanks for doing this Wei. Can you possibly do one more thing: can you add a test that is an integration test between plane wave and dual representations that verifies that two very small models are the Fourier transform of each other even when an even number of modes is used? I know the Fourier transform code is slow but it should be okay to do it on very small models, like 2 by 2 and 6 by 1.
babbush
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.