Feature/cleanup eslint errors #295
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/drewclem/protege/CKaDNATNGsFyEMEvdq1uZQ9CtX7K |
| @@ -1,4 +1,5 @@ | |||
| import React from 'react' | |||
| // TODO: Formik is being imported but it not currently a dependency in package.json. | |||
There was a problem hiding this comment.
@drewclem This seems like it was left over from pre-next? As far as I can tell, this component isn't used at all. Should we just delete it?
There was a problem hiding this comment.
Yeah, safe to remove altogether
| const [activeApplications, setActiveApplications] = useState() | ||
|
|
||
| useEffect(() => { | ||
| // TODO: What should happen with this fn? It's not being used anywhere. | ||
| // eslint-disable-next-line no-unused-vars |
There was a problem hiding this comment.
This component can be removed. It was original the dashboard view for company accounts, but that has been refactored
| @@ -56,6 +56,7 @@ const JobList = () => { | |||
| <ul> | |||
| {activeApplications && | |||
| activeApplications.map((job) => { | |||
| // TODO: ? | |||
| return <JobItem job={job} key={job.id} /> | |||
There was a problem hiding this comment.
@drewclem This component doesn't exist as far as I can tell. Should we remove any components like this from the jobs page for now?
There was a problem hiding this comment.
Yeah, that sounds good. I'm not sure how some of these came to be- other than getting left behind while iterating
| const [activeApplications, setActiveApplications] = useState() | ||
|
|
||
| useEffect(() => { | ||
| // TODO: What should happen with this fn? It's not being used anywhere. | ||
| // eslint-disable-next-line no-unused-vars |
There was a problem hiding this comment.
This component can be removed. It was original the dashboard view for company accounts, but that has been refactored
| @@ -56,6 +56,7 @@ const JobList = () => { | |||
| <ul> | |||
| {activeApplications && | |||
| activeApplications.map((job) => { | |||
| // TODO: ? | |||
| return <JobItem job={job} key={job.id} /> | |||
There was a problem hiding this comment.
Yeah, that sounds good. I'm not sure how some of these came to be- other than getting left behind while iterating
|
This is looking good. Where are we on this PR? Can we merge it in? |
|
@sethburtonhall it's still in progress. @seanwash will flip it to Ready to Review when he's done with it |
|
Yep sorry, I'll try to finish this up this evening! |
|
Sounds good!! |
Description
What does this PR do?
It cleans up all of the outstanding eslint errors.