Bug fixes: Post a Job, a11y issues #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#151
A11y Issues (per AxeV4.6.1 Chrome extension):
Page must contain a level-one heading (x1)
Solved: added an H1 at the top of the page, "Post a Job", to src/pages/PostAJob.js
Also changed "Inexperience..." status alert from H1 to H2 to avoid hierarchy confusion when the alert is shown.
Buttons must have descriptive text (x17)
x1 = Solved: added aria-label='navigation' to .nav-button in src/globel/Nav.js
x16 = All related to the Job Description editor created with react-quill which has it's own accessibility issues (see quilljs/quill, Suggestions for toolbar accessibility #2038
svg elements with an img role have an alternative text (x4)
Elements must have sufficient color contrast (x6)
Files edited:
Remaining Issues
With these changes, Lighthouse score has improved to 94 (from 92).