Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes: Post a Job, a11y issues #224

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

kldickenson
Copy link
Contributor

#151

A11y Issues (per AxeV4.6.1 Chrome extension):

  • Page must contain a level-one heading (x1)
    Solved: added an H1 at the top of the page, "Post a Job", to src/pages/PostAJob.js
    Also changed "Inexperience..." status alert from H1 to H2 to avoid hierarchy confusion when the alert is shown.

  • Buttons must have descriptive text (x17)
    x1 = Solved: added aria-label='navigation' to .nav-button in src/globel/Nav.js
    x16 = All related to the Job Description editor created with react-quill which has it's own accessibility issues (see quilljs/quill, Suggestions for toolbar accessibility #2038

  • svg elements with an img role have an alternative text (x4)

    • x1 = Solved: added title='mobile menu icon' to src/assets/images/svg/menu-icon.js
    • x3 = Solved: added title to SVG in src/assets/images/svg/check-solid.js
  • Elements must have sufficient color contrast (x6)

    • All on PostAJob.js
    • x1 = Solved: "disclaimer" .text-xs.opacity-75, upped text wight to text-blue-900
    • x1 = Solved: "Select Your Tier", upped text weight to text-teal-900, would work with text-blue-900 as well
    • x2 = Solved: "How to Apply" radio buttons, added .text-blue-800 on label tags
    • x2 = Ignored: Warnings for h2s with black text and textured backgrounds. They look fine.

Files edited:

  • src/pages/PostAJob.js (H1 and color contrast issues)
  • src/components/form/PostAJobForm.js (color contrast)
  • src/components/global/Nav.js (button text issue)
  • assets/images/svg/menu-icon.js (svg issue)
  • assets/images/svg/check-solid.js (svg issue)

Remaining Issues

With these changes, Lighthouse score has improved to 94 (from 92).

bug fixes for accessibility issues found with Axe
@netlify
Copy link

netlify bot commented Nov 30, 2020

‼️ Deploy request for affectionate-goldberg-7cf473 rejected.
Learn more about Netlify's sensitive variable policy

🔨 Explore the source changes: 311b401

KLD specific package.json  and package-lock.json
Copy link
Collaborator

@drewclem drewclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@drewclem drewclem merged commit cda5f4d into ProjectProtege:develop Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants