-
This is what it is said in the README in the Foundry Tests section:
However, by peeking at the Foundry tests, I can see that you are not not deploying pre-compiled versions of all contracts. You are only deploying the optimized versions of the following contracts: For all other contracts, e.g. My question is why? Why are you selectively deploying a few select pre-compiled contracts, and not all? If I understand this correctly, the Is it that the chosen contracts are particularly large, and it's them who caused most of the lag when running the tests with Whatever the case, I think that it would be worth it to clarify this in the README for future contributors! |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 4 replies
-
Hey Paul, In the full CI workflow, we pre-compile the optimized byte code for the smart contracts and test against them using the Thanks for taking a look! And I’ll work on getting the documentation updated for the 1.2 release. |
Beta Was this translation helpful? Give feedback.
Hey Paul,
For the latest approaches, make sure you’re taking a look at the 1.2 branch here: https://github.com/ProjectOpenSea/seaport/tree/1.2 (though read me and documentation still need to be updated). Most of the relevant stuff lives in
foundry.toml
andBaseConsiderationTest
(and the GH actions test yaml config).In the full CI workflow, we pre-compile the optimized byte code for the smart contracts and test against them using the
test
profile for the three you mentioned. It’s possible there are some places we are still normally deploying the code (SignatureVerifier is an interesting example, as the test contract inherits the signature verification logic directly).However, the example…