Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tx override params #373

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Add more tx override params #373

merged 4 commits into from
Oct 13, 2023

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Oct 10, 2023

Extends #363 to add overrides to more methods that send txs

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1f9f820) 98.16% compared to head (074f196) 98.17%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   98.16%   98.17%           
=======================================
  Files          33       34    +1     
  Lines       14035    14068   +33     
  Branches      673      673           
=======================================
+ Hits        13778    13811   +33     
  Misses        252      252           
  Partials        5        5           
Files Coverage Δ
src/constants.ts 100.00% <100.00%> (ø)
src/seaport.ts 96.88% <100.00%> (+0.06%) ⬆️
test/basic-fulfill.spec.ts 100.00% <100.00%> (ø)
test/cancel.spec.ts 100.00% <100.00%> (ø)
test/domain-registry.spec.ts 100.00% <100.00%> (ø)
test/fulfill-orders.spec.ts 99.37% <100.00%> (-0.01%) ⬇️
test/partial-fulfill.spec.ts 100.00% <100.00%> (ø)
test/utils/constants.ts 100.00% <100.00%> (ø)
test/create-order.spec.ts 99.90% <66.66%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanio ryanio merged commit db93843 into main Oct 13, 2023
5 checks passed
@ryanio ryanio deleted the ryan/add-more-tx-overrides branch October 13, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants