-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support level 0 IIIF images #2616
Comments
Hi, seconding question/need for this and #520. But also the need for simply no Should i open a new issue to target beta3 or adding here is good enough? Looking at the code in Beta3 i see that fetchInfoResponse is always called. mirador/src/state/actions/infoResponse.js Line 70 in e739c84
service definition in aIIIF Manifest version 2.1 TypeError: undefined is not an object (evaluating 'e.getImages()[0].getResource().getServices()[0].id') At least for version 2.1 the specs, the way i read them (can be wrong) imply that service is only needed if exists. From the specs at https://iiif.io/api/presentation/2.1/#image-resources
Our use case for this is related to static served images as everyone elses, but also to one edge case Given an Image Resource with a given "resource":{ "@id": "http://localhost:8183/iiif/2/81e%2Fapplication-multi-size2-cff793b4-058d-4729-8d4d-befdd000969f.pdf/full/full/0/default.jpg?page=2 See the added GET argument of page=2. We want to use Cantaloupe's Page PDF extraction capabilities. That @id is correct and returns second page of a PDF. Without the Service, Mirador 3 fails to display/access the Image, if we add We fixed this on the IABookreader implementation by getting arguments and moving them after the info.json, but also by allowing non service exposed images to be served. Is this something else could need? Thanks a lot |
Thanks both @jsbien and @DiegoPino for raising this. #2976 aims to fix this for Presentation v2, and you can test if it works for you here: https://deploy-preview-2976--mirador-dev.netlify.app/__tests__/integration/mirador/ |
On Thu, Apr 16 2020 at 16:27 -07, Jack Reed wrote:
Thanks both @jsbien and @DiegoPino for raising this. #2976 aims to fix this for Presentation v2, and you can test if it works for you here:
https://deploy-preview-2976--mirador-dev.netlify.app/__tests__/integration/mirador/
I've added my resource
https://jsbien.github.io/Parkosz4IIIF/collection/ParkoszJBC/index.json
which was accepted but only the metadata are displayed.
Am I doing something wrong or there is still a problem in Mirador?
Best regards
Janusz
…--
,
Janusz S. Bien
emeryt (emeritus)
https://sites.google.com/view/jsbien
|
@jsbien Thanks for the quick reply. I think the initial implementation only supports IIIF Presentation v2. I think if you converted to v2 things should work, or we could also look at adding v3 support. |
On Fri, Apr 17 2020 at 6:28 -07, Jack Reed wrote:
@jsbien Thanks for the quick reply. I think the initial implementation
only supports IIIF Presentation v2. I think if you converted to v2
things should work, or we could also look at adding v3 support.
I'm sorry but I just use
https://github.com/UniversalViewer/uv-app-starter
without fully understanding how it works. Moreover my only goal is to
display
https://jsbien.github.io/Parkosz4IIIF/
in Mirador to allow to compare the versions easily.
Please be more explicit in your suggestions. Should I request a
modification of uv-app-starter?
|
@mejackreed this is great! Thank you so much 👏 =) Looking at the committed code i deduce it will work on V2 manifest only, right? Not an issue, just want to be sure. We can deal with both so pretty happy!! Which is the next published Tag/Beta that will get this commit? To update our library dependencies. Cheers and thanks again, great work |
An update to @jsbien and @DiegoPino , I'm working on supporting Presentation v3 and so will hopefully have a pull request in shortly. @DiegoPino this will get released in v3.0.0-beta.7 and that should get released as soon as the lingering table of contents and others get reviewed. Hopefully soon. |
Also @jsbien I found another issue with the manifests you created which you may want to request modification to uv-app-starter. The canvases do not have |
On Fri, Apr 17 2020 at 8:08 -07, Jack Reed wrote:
Also @jsbien I found another issue with the manifests you created
which you may want to request modification to uv-app-starter. The
canvases do not have height and width properties which they must have.
|
This would allow to view images posted at GitHub Pages, such as
https://jsbien.github.io/Parkosz4IIIF/collection/ParkoszJBC/index.json
https://jsbien.github.io/Parkosz4IIIF/collection/ParkoszMF/index.json
https://jsbien.github.io/Parkosz4IIIF/collection/ParkoszPWN/index.json
This actually is a specific case of the still open issue #520.
The text was updated successfully, but these errors were encountered: