-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata panel does not render metadata with multiple values properly #2591
Comments
Hi @regisrob! Thanks for including fixtures. We are aware of the problem. Unfortunately, this is an issue that will need to be resolved upstream in IIIF-Commons/manifesto. The other option would be to stop using manifesto, but writing our own utilities for Mirador would be a larger undertaking. |
I understand, thanks @camillevilla. Indeed it would be better to fix this in Manifesto, but I guess there are other issues at stake with this library |
I've just checked with the latest master branch of Manifesto which includes @mejackreed 's fix (#60), but it does not seem to solve the problem in Mirador, at least for this Manifest (that has canvas-level metadata with an array of values in one of the key/value pairs). Am I missing something? |
@regisrob , once manifesto releases a new version we can update this method to |
Ok i see, there is still some work to do on the Mirador side then. Thanks @mejackreed |
Considering this fixture Manifest with canvas-level metadata: http://beta.biblissima.fr/iiif/manifest/ark:/43093/desc57cb76cd3739a24a9277b6669d95b5f3a590e771. M3 only displays the first value of an array of values from
metadata
, e.g. for the first canvas there is only one link associated with the "Descripteurs" label (there should be 7, as listed in the Manifest):Another fixture with the same issue: https://data.ucd.ie/api/img/manifests/ucdlib:33064. M3 only displays one "topic-LCSH" out of the two listed in the Manifest
metadata
.A third fixture for a similar case is https://iiif.io/api/presentation/2.1/example/fixtures/4/manifest.json ("Test 4 Manifest: Metadata Pairs with Multiple Values in same Language"), which seems to break M3 (maybe because there is no
service
for the image?)The text was updated successfully, but these errors were encountered: