Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata panel does not render metadata with multiple values properly #2591

Closed
regisrob opened this issue Apr 24, 2019 · 5 comments
Closed
Milestone

Comments

@regisrob
Copy link
Contributor

Considering this fixture Manifest with canvas-level metadata: http://beta.biblissima.fr/iiif/manifest/ark:/43093/desc57cb76cd3739a24a9277b6669d95b5f3a590e771. M3 only displays the first value of an array of values from metadata, e.g. for the first canvas there is only one link associated with the "Descripteurs" label (there should be 7, as listed in the Manifest):

Capture d’écran 2019-04-24 à 11 36 27

{
  "value": [
    "<a href=\"http://beta.biblissima.fr//ark:/43093/desc4029aaec9af3ff426a159f956f7a20689b56f2d2\">Lances</a>",
    "<a href=\"http://beta.biblissima.fr//ark:/43093/desc98ecb295b467f7c35070d9ebb076892e297a92b8\">Coiffes</a>",
    "<a href=\"http://beta.biblissima.fr//ark:/43093/desc78ec63596ada325e05f7b5d0bb2bc0598223cf69\">Combat</a>",
    "<a href=\"http://beta.biblissima.fr//ark:/43093/desc7e1644ea589418163cc71f41d158446c29c82628\">Arcs</a>",
    "<a href=\"http://beta.biblissima.fr//ark:/43093/desc02c69ac510a1ade350f688f9100fb94a12625dd4\">Groupes ethniques</a>",
    "<a href=\"http://beta.biblissima.fr//ark:/43093/desc905495aa17391ff09b1fae50937c4522d3d6f77d\">Homme sauvage</a>",
    "<a href=\"http://beta.biblissima.fr//ark:/43093/desc57cb76cd3739a24a9277b6669d95b5f3a590e771\">Centaures</a>"
  ],
  "label": "Descripteurs"
}

Another fixture with the same issue: https://data.ucd.ie/api/img/manifests/ucdlib:33064. M3 only displays one "topic-LCSH" out of the two listed in the Manifest metadata.

A third fixture for a similar case is https://iiif.io/api/presentation/2.1/example/fixtures/4/manifest.json ("Test 4 Manifest: Metadata Pairs with Multiple Values in same Language"), which seems to break M3 (maybe because there is no service for the image?)

@camillevilla
Copy link
Member

Hi @regisrob! Thanks for including fixtures. We are aware of the problem. Unfortunately, this is an issue that will need to be resolved upstream in IIIF-Commons/manifesto.

The other option would be to stop using manifesto, but writing our own utilities for Mirador would be a larger undertaking.

@regisrob
Copy link
Contributor Author

regisrob commented May 6, 2019

I understand, thanks @camillevilla. Indeed it would be better to fix this in Manifesto, but I guess there are other issues at stake with this library

@regisrob
Copy link
Contributor Author

regisrob commented Apr 29, 2020

I've just checked with the latest master branch of Manifesto which includes @mejackreed 's fix (#60), but it does not seem to solve the problem in Mirador, at least for this Manifest (that has canvas-level metadata with an array of values in one of the key/value pairs). Am I missing something?

@mejackreed
Copy link
Collaborator

@regisrob , once manifesto releases a new version we can update this method to getValues() which should resolve this issue.

@regisrob
Copy link
Contributor Author

Ok i see, there is still some work to do on the Mirador side then. Thanks @mejackreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants