Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

fix: updates to Docker images for consistency across Gateway services #91

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

JoeCap08055
Copy link
Contributor

@JoeCap08055 JoeCap08055 commented Apr 17, 2024

  • updated CMD to ENTRYPOINT
  • eliminated build stage from dev.Dockerfile
  • added '--watch' parameter for use with dev Docker image/docker-compose
  • Gave dev docker-compose services an image name so that the 2 app services can share a local image

Closes #88

- updated CMD to ENTRYPOINT
- eliminated build stage from dev.Dockerfile
- added  '--watch' parameter for use with dev Docker image/docker-compose
- Gave dev docker-compose services an image name so that the 2 app services can share a local image
@JoeCap08055 JoeCap08055 linked an issue Apr 17, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

docker-compose.dev.yaml Show resolved Hide resolved
Copy link
Contributor

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

@JoeCap08055 JoeCap08055 merged commit 66d585a into main Apr 18, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish production-ready Docker image
3 participants