feat: sync env vars for Gateway #90
Conversation
- Remove unused env vars - Honor API_PORT - Rename ENVIRONMENT to CHAIN_ENVIRONMENT - Make ConfigService getters consistent with other services - Add doc comments to env.template - Add ENVIRONMENT.md - Update README
| PROVIDER_ACCOUNT_SEED_PHRASE: string; | ||
| CAPACITY_LIMIT: ICapacityLimit; | ||
| FILE_UPLOAD_MAX_SIZE_IN_BYTES: number; |
There was a problem hiding this comment.
Even though this is not being used directly from config I think it would help to keep it around for future and consistency between the env variables and config fields . This configuration has being used directly inside ApiController since I couldn't find an easy way to inject the config service inside there.
There was a problem hiding this comment.
fixed--I restored this to the environment, and found a way to honor it from the ConfigService using async default module options
There was a problem hiding this comment.
Awesome, I would lower this value for test and check to ensure it does limit the uploaded file and works as expected
There was a problem hiding this comment.
Yes, I did that--errored as expected.
Description
Closes #86