Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

fix(batch-worker): schema breaking changes #85

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

enddynayn
Copy link
Contributor

@enddynayn enddynayn commented Mar 28, 2024

Schema changes due to limiting the size of POV created breaking changes to how schemas are accessed.

Update how schemas are queried to ensure that a schema payload is returned.

ProjectLibertyLabs/gateway#278

@enddynayn enddynayn force-pushed the fix/frequency-schema-breaking-changes-issue-84 branch 3 times, most recently from f4a3bfe to 81280cb Compare March 28, 2024 21:41
Schema changes due to limiting the size of POV created
breaking change to how schemas are accessed.

Update how schemas are queried to ensure that a schema payload
is returned.

issue-84
@enddynayn enddynayn force-pushed the fix/frequency-schema-breaking-changes-issue-84 branch from 81280cb to 0a01160 Compare March 28, 2024 21:44
@enddynayn enddynayn marked this pull request as ready for review March 28, 2024 21:46
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for fixing. This can be further improved by directly fetching schemas by their names instead of relying on hardcoded ids

Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@enddynayn
Copy link
Contributor Author

Good idea. I'll create a ticket for it.

@enddynayn enddynayn merged commit 4f9e8ff into main Mar 29, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants