This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
using atomic transactions #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To be able to eliminate partial failures as much as possible we need to use transactions as much as possible. This was not easily achievable when we have a mix of redis operations and bullmq jobs. Since bullmq jobs use lua scripts to publish it seems like it is not possible to wrap them inside a transaction and need to be careful about the order of operations and side-effects.
When we have only redis operations the best way to achieve atomicity is to use lua scripts which is what we are doing for batching.
closes #29