This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Request processor to queue respective announcements #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraswatpuneet
changed the title
saraswatpuneet
commented
Sep 7, 2023
aramikm
reviewed
Sep 8, 2023
apps/worker/src/request_processor/dsnp.announcement.processor.ts
Outdated
Show resolved
Hide resolved
apps/worker/src/request_processor/dsnp.announcement.processor.ts
Outdated
Show resolved
Hide resolved
apps/worker/src/request_processor/dsnp.announcement.processor.ts
Outdated
Show resolved
Hide resolved
apps/worker/src/request_processor/dsnp.announcement.processor.ts
Outdated
Show resolved
Hide resolved
apps/worker/src/request_processor/dsnp.announcement.processor.ts
Outdated
Show resolved
Hide resolved
apps/worker/src/request_processor/dsnp.announcement.processor.ts
Outdated
Show resolved
Hide resolved
apps/worker/src/request_processor/dsnp.announcement.processor.ts
Outdated
Show resolved
Hide resolved
apps/worker/src/request_processor/dsnp.announcement.processor.ts
Outdated
Show resolved
Hide resolved
aramikm
approved these changes
Sep 8, 2023
apps/worker/src/request_processor/dsnp.announcement.processor.ts
Outdated
Show resolved
Hide resolved
| private async prepareImageAttachment(asset: AssetDto): Promise<ActivityContentImage> { | ||
| const imageLinks: ActivityContentImageLink[] = []; | ||
| asset.references?.forEach(async (reference) => { | ||
| const assetMetaData = await this.assetQueue.getJob(reference.referenceId); |
There was a problem hiding this comment.
So each job should be independent from other jobs. We should not expect this to resolve. This is not a blocker and going to address it in another PR.
There was a problem hiding this comment.
Yeah i was a bit confused about it, but lets fix it in next
Co-authored-by: Aramik <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
DsnpAnnouncementProcessorDsnpAnnouncementProcessor: takes aIRequestJoband parses it in respective DSNPAnnouncementsCloses: Request processor #11